Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add kind gep in PR template #720

Merged
merged 1 commit into from
Jul 13, 2021

Conversation

hbagdi
Copy link
Contributor

@hbagdi hbagdi commented Jul 13, 2021

What type of PR is this?

/kind cleanup
What this PR does / why we need it:
Add a /kind gep to the PR template.

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jul 13, 2021
@k8s-ci-robot k8s-ci-robot requested a review from danehans July 13, 2021 23:10
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hbagdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from thockin July 13, 2021 23:10
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 13, 2021
@robscott
Copy link
Member

I actually didn't realize that would work, I had just been adding the label manually. Thanks for adding this!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 13, 2021
@k8s-ci-robot k8s-ci-robot merged commit b821539 into kubernetes-sigs:master Jul 13, 2021
@hbagdi
Copy link
Contributor Author

hbagdi commented Jul 14, 2021

I actually didn't realize that would work, I had just been adding the label manually. Thanks for adding this!

I actually got the idea from your PR where you used the command:
#715 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants