Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor improvements to navigation on docs site #761

Merged
merged 1 commit into from
Aug 10, 2021
Merged

minor improvements to navigation on docs site #761

merged 1 commit into from
Aug 10, 2021

Conversation

hbagdi
Copy link
Contributor

@hbagdi hbagdi commented Aug 10, 2021 •
edited
Loading

What type of PR is this?

/kind cleanup
What this PR does / why we need it:

  • every markdown heading as a link
  • every page has an edit button to directly edit a page and submit a PR
  • Github repository improvements in the header
  • searched term is highlighted in the result
    Which issue(s) this PR fixes:

None

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 10, 2021
@k8s-ci-robot k8s-ci-robot requested review from bowei and robscott August 10, 2021 21:11
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2021
@hbagdi hbagdi force-pushed the docs/minor-improvements branch from bb3036d to 89230b6 Compare August 10, 2021 21:13
@hbagdi hbagdi force-pushed the docs/minor-improvements branch from 89230b6 to a98c6ec Compare August 10, 2021 21:18
@robscott
Copy link
Member

Great improvements, thanks!

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hbagdi, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 10, 2021
@k8s-ci-robot k8s-ci-robot merged commit 315fecb into kubernetes-sigs:master Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowei bowei Awaiting requested review from bowei

@robscott robscott Awaiting requested review from robscott

Assignees

@robscott robscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hbagdi @robscott @k8s-ci-robot