Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1alpha2 validation fix/update #831

Closed
wants to merge 29 commits into from
Closed

v1alpha2 validation fix/update #831

wants to merge 29 commits into from

Conversation

ccfishk
Copy link
Contributor

@ccfishk ccfishk commented Aug 26, 2021

What type of PR is this?

/kind bug
/kind cleanup

What this PR does / why we need it:
Fix/Update v1alpha2 validation modules
Which issue(s) this PR fixes:

Fixes #
PR #780 is super slow
Fixes ##826
Does this PR introduce a user-facing change?:


@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 26, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ccfishk
To complete the pull request process, please assign robscott after the PR has been reviewed.
You can assign the PR to them by writing /assign @robscott in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Hi @ccfishk. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 26, 2021
@k8s-ci-robot k8s-ci-robot requested review from hbagdi and thockin August 26, 2021 03:47
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 26, 2021
@robscott
Copy link
Member

Thanks @ccfishk!

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 26, 2021
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this @ccfishk!

apis/v1alpha2/validation/gateway.go Outdated Show resolved Hide resolved
apis/v1alpha2/validation/httproute.go Outdated Show resolved Hide resolved
apis/v1alpha2/validation/httproute.go Outdated Show resolved Hide resolved
apis/v1alpha2/validation/httproute_test.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 30, 2021
@ccfishk ccfishk changed the title [wip] v1alpha2 validation fix/update v1alpha2 validation fix/update Aug 30, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 30, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 1, 2021
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work on this @ccfishk! This mostly LGTM, just a few more nits.

apis/v1alpha2/validation/httproute_test.go Outdated Show resolved Hide resolved
apis/v1alpha2/validation/httproute_test.go Outdated Show resolved Hide resolved
pkg/util/utils_test.go Outdated Show resolved Hide resolved
apis/v1alpha2/validation/httproute_test.go Outdated Show resolved Hide resolved
apis/v1alpha2/validation/httproute_test.go Show resolved Hide resolved
apis/v1alpha2/validation/httproute_test.go Show resolved Hide resolved
@robscott robscott added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Sep 2, 2021
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ccfishk! Just some tiny nits but otherwise LGTM.

apis/v1alpha2/validation/httproute.go Outdated Show resolved Hide resolved
apis/v1alpha2/validation/httproute_test.go Outdated Show resolved Hide resolved
pkg/util/utils_test.go Outdated Show resolved Hide resolved
pkg/util/utils_test.go Outdated Show resolved Hide resolved
@youngnick
Copy link
Contributor

Looks like this one is pretty close @ccfishk, any chance you could finish it up?

@youngnick youngnick added this to the v1alpha2 milestone Sep 21, 2021
@k8s-ci-robot
Copy link
Contributor

@ccfishk: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 24, 2021
@shaneutt shaneutt mentioned this pull request Sep 27, 2021
@ccfishk
Copy link
Contributor Author

ccfishk commented Sep 27, 2021

Hi, @youngnick @robscott, need migrate this PR to a new PR to finish this up due to account issue, is this OK ?

Jimin Hu and others added 2 commits September 27, 2021 13:32
Co-authored-by: Rob Scott <rob.scott87@gmail.com>
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 27, 2021
@k8s-ci-robot
Copy link
Contributor

@ccfishk: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gateway-api-verify 9b7324e link true /test pull-gateway-api-verify
pull-gateway-api-test 9b7324e link true /test pull-gateway-api-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ccfishk
Copy link
Contributor Author

ccfishk commented Sep 28, 2021

The PR and its solution is moved to #883.
Plan to close as it is.

@ccfishk ccfishk closed this Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants