Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make MirrorFilter.BackendRef required #837

Merged
merged 1 commit into from
Aug 30, 2021
Merged

Make MirrorFilter.BackendRef required #837

merged 1 commit into from
Aug 30, 2021

Conversation

howardjohn
Copy link
Contributor

@howardjohn howardjohn commented Aug 27, 2021 •
edited
Loading

/kind cleanup

/kind api-change

Currently this is optional. I cannot see any reason why it would not be
required, as the whole point of mirroring is the request goes to some
backend?

Does this PR introduce a user-facing change?:

* Make `MirrorFilter.BackendRef` a required field when the mirror filter is used

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 27, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @howardjohn. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 27, 2021
@k8s-ci-robot k8s-ci-robot requested review from hbagdi and jpeach August 27, 2021 21:07
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 27, 2021
robscott
robscott reviewed Aug 27, 2021
View reviewed changes
apis/v1alpha2/httproute_types.go Outdated
//
// +optional
BackendRef *BackendObjectReference `json:"backendRef,omitempty"`
BackendRef BackendObjectReference `json:"backendRef,omitempty"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
BackendRef BackendObjectReference `json:"backendRef,omitempty"`
BackendRef BackendObjectReference `json:"backendRef"`

@robscott
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 27, 2021
@howardjohn howardjohn force-pushed the mirror/backend-required branch from bb9369f to 791ea17 Compare August 27, 2021 21:18
hbagdi
hbagdi reviewed Aug 30, 2021
View reviewed changes
apis/v1alpha2/httproute_types.go
//
// +optional
BackendRef *BackendObjectReference `json:"backendRef,omitempty"`
BackendRef BackendObjectReference `json:"backendRef"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failing because tests are not compiling.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, should be good now

@hbagdi
Copy link
Contributor

hbagdi commented Aug 30, 2021

LGTM from an API perspective.

@howardjohn
Make MirrorFilter.BackendRef required
4c171a6 
Currently this is optional. I cannot see any reason why it would not be
required, as the whole point of mirroring is the request goes to some
backend?
@howardjohn howardjohn force-pushed the mirror/backend-required branch from 791ea17 to 4c171a6 Compare August 30, 2021 19:57
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 30, 2021
@hbagdi
Copy link
Contributor

hbagdi commented Aug 30, 2021

@howardjohn Can you update the release notes section of the PR description so that it makes sense to controller authors and end-users?

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 30, 2021
@robscott
Copy link
Member

Thanks!

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: howardjohn, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2021
@k8s-ci-robot k8s-ci-robot merged commit a4fc2e2 into kubernetes-sigs:master Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbagdi hbagdi hbagdi left review comments

@robscott robscott robscott left review comments

@jpeach jpeach Awaiting requested review from jpeach

Assignees

@hbagdi hbagdi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@howardjohn @k8s-ci-robot @robscott @hbagdi