httproute: drop ImplementationSpecific match types #850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImplementationSpecific is trappy match type: it provides an escape hatch to do more but it doesn't take into account that multiple implementation-specific match types could be possible. Use-cases exist in this area but we have not thought through them deeply. Being conservative and dropping this feature in v1alpha2 to avoid any potential breaking change in future. We may revisit this in future as we gain a better understanding. For kubernetes-sigs#832
k8s-ci-robot
added
kind/api-change
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hbagdi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Adding a hold for one more person to sign off on this, but LGTM. /lgtm |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
/lgtm |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind api-change
What this PR does / why we need it:
ImplementationSpecific is trappy match type: it provides an escape hatch
to do more but it doesn't take into account that multiple
implementation-specific match types could be possible. Use-cases exist
in this area but we have not thought through them deeply.
Being conservative and dropping this feature in v1alpha2 to avoid any potential
breaking change in the future. We may revisit this in the future as we gain a
better understanding.
Which issue(s) this PR fixes:
Fixes #832
Does this PR introduce a user-facing change?: