-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce wildcardhostname field #956
Introduce wildcardhostname field #956
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Hi @stevesloka. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can we add a test case 'wildcard hostname on the redirect filter fails'? You can do so by adding it to hack/invalid-examples. |
/ok-to-test |
/check-cla |
3f94d1d
to
55bb6b6
Compare
@hbagdi I added an invalid test case for the redirect hostname. |
LGTM once the field name changes are done as discussed. |
@stevesloka I was about to release 0.4.1, but realized this change also probably belongs in that release. Agree with @youngnick that this PR LGTM once that final name change gets in. |
55bb6b6
to
c4e4ae6
Compare
@robscott sorry for loosing track of this one, I've updated the PR with the PreciseHostname. Thanks! |
…card value and precise value for hostnames. Updates the HTTPRequestRedirectFilter.Hostname to use the new PreciseHostname type which validates the value cannot contain wildcard characters. Signed-off-by: Steve Sloka <slokas@vmware.com>
Signed-off-by: Steve Sloka <slokas@vmware.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/lgtm
/approve
Signed-off-by: Steve Sloka <slokas@vmware.com>
01f25e3
to
db11392
Compare
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jpeach, robscott, stevesloka The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Woops, we missed the hold on this. /hold cancel |
Cherry Pick #956 into release-0.4
What type of PR is this?
/kind bug
Optionally add one or more of the following kinds if applicable:
/kind api-change
What this PR does / why we need it:
Update the HTTPRequestRedirectFilter.Hostname to use a Hostname type which validates the value cannot
contain wildcard characters. Updates all other references which used Hostname to use WildcardHostname
which does allow for wildcard characters.
Signed-off-by: Steve Sloka slokas@vmware.com
Which issue(s) this PR fixes:
Fixes #949
Does this PR introduce a user-facing change?: