Skip to content

Commit

Permalink
test: fix kind cluster test cleanup flakes (#1399)
Browse files Browse the repository at this point in the history
  • Loading branch information
njtran committed Jul 8, 2024
1 parent 4d55a39 commit bcd33e9
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 1 addition & 1 deletion hack/install-kwok.sh
Original file line number Diff line number Diff line change
Expand Up @@ -112,8 +112,8 @@ crdURL="https://github.com/${KWOK_REPO}/releases/download/${KWOK_RELEASE}/stage-
# Set UNINSTALL_KWOK=true if you want to uninstall.
if [[ ${UNINSTALL_KWOK} = "true" ]]
then
kubectl delete -f ${HOME_DIR}/kwok.yaml
kubectl delete -f ${crdURL}
kubectl delete -f ${HOME_DIR}/kwok.yaml
else
kubectl apply -f ${HOME_DIR}/kwok.yaml
kubectl apply -f ${crdURL}
Expand Down
1 change: 0 additions & 1 deletion test/pkg/environment/common/setup.go
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,6 @@ func (env *Environment) CleanupObjects(cleanableObjects ...client.Object) {
defer GinkgoRecover()
g.Expect(env.ExpectTestingFinalizerRemoved(&metaList.Items[i])).To(Succeed())
g.Expect(client.IgnoreNotFound(env.Client.Delete(env, &metaList.Items[i],
client.PropagationPolicy(metav1.DeletePropagationForeground),
&client.DeleteOptions{GracePeriodSeconds: lo.ToPtr(int64(0))}))).To(Succeed())
})
// If the deletes eventually succeed, we should have no elements here at the end of the test
Expand Down

0 comments on commit bcd33e9

Please sign in to comment.