fix: Fix an issue where the instanceTypes aren't sorted before truncating it for spot-to-spot consolidation.

[nikmohan123]

Fix an issue where the instanceTypes aren't sorted before truncating it for spot-to-spot consolidation.

Description

As part of spot-to-spot consolidation algorithm (ref: here), we check for minimum flexibility of the instance types and if it is greater than 15, we allow spot-to-spot consolidation. To avoid continual consolidation, we were supposed to sort the spot instance types by prices and truncate the list to 15 instance types to be sent to launch API.

The sorting of spot instance types by prices was missed and this fixes the issue.

How was this change tested?
Added a functional test. Tested with and without the fix. It fails when the sorting is not place.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[k8s-ci-robot]

Hi @nikmohan123. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jonathan-innis]

/lgtm
/approve

[coveralls]

Pull Request Test Coverage Report for Build 7920197671

Details

• 0 of 1 (100.0%) changed or added relevant line in 1 file are covered.
• 2 unchanged lines in 1 file lost coverage.
• Overall coverage decreased (-0.02%) to 80.656%

---

Files with Coverage Reduction	New Missed Lines	%
pkg/controllers/disruption/drift.go	2	90.63%

Totals
Change from base Build 7919997209:	-0.02%
Covered Lines:	7972
Relevant Lines:	9884

---

💛 - Coveralls

[jonathan-innis]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jonathan-innis, nikmohan123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jonathan-innis]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment