-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add pod/node count to metrics and logs for disruption #1025
chore: Add pod/node count to metrics and logs for disruption #1025
Conversation
123fbc5
to
32d45c5
Compare
Pull Request Test Coverage Report for Build 7963757649Details
💛 - Coveralls |
32d45c5
to
7e40fa6
Compare
Very useful metrics, excited to see this! |
7e40fa6
to
0d0c71d
Compare
0d0c71d
to
d1ddb23
Compare
@Bryce-Soghigian Thanks for the feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: engedaam, jonathan-innis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #N/A
Description
This adds a disrupted reschedulable pod count metric along with a disrupted node count metric. This also adds a pod count to the log that is printed when we disrupt nodes. This would help in debugging issues like in #1014 where it's tough to tell if a node is terminated with nodes bound or not.
How was this change tested?
make presubmit
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.