-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Don't require message or reason to be set for NodeClaim status conditions #1254
chore: Don't require message or reason to be set for NodeClaim status conditions #1254
Conversation
Skipping CI for Draft Pull Request. |
Pull Request Test Coverage Report for Build 9085566370Details
💛 - Coveralls |
68ef658
to
53afec4
Compare
53afec4
to
3a73163
Compare
e1b255c
to
05deb0f
Compare
05deb0f
to
6f20f8d
Compare
6f20f8d
to
4729c53
Compare
c82d74a
to
83f847a
Compare
83f847a
to
b9f4a0e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jonathan-innis, njtran The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #N/A
Description
This change ensures that our use of
metav1.Condition
doesn't cause validation failures when making updates to the NodeClaim. We can drop this injected removal of these required fields when we get to v1, where we can use conversion to automatically set these values.How was this change tested?
make presubmit
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.