Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Don't require message or reason to be set for NodeClaim status conditions #1254

Conversation

jonathan-innis
Copy link
Member

@jonathan-innis jonathan-innis commented May 13, 2024

Fixes #N/A

Description

This change ensures that our use of metav1.Condition doesn't cause validation failures when making updates to the NodeClaim. We can drop this injected removal of these required fields when we get to v1, where we can use conversion to automatically set these values.

How was this change tested?

make presubmit

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 13, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 13, 2024
@jonathan-innis jonathan-innis changed the title chore: Don't require message or reason to be set chore: Don't require message or reason to be set for NodeClaims May 13, 2024
@coveralls
Copy link

coveralls commented May 13, 2024

Pull Request Test Coverage Report for Build 9085566370

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 78.546%

Totals Coverage Status
Change from base Build 9082374003: 0.02%
Covered Lines: 8318
Relevant Lines: 10590

💛 - Coveralls

@jonathan-innis jonathan-innis force-pushed the no-require-nodeclaim-condition-status branch 3 times, most recently from 68ef658 to 53afec4 Compare May 14, 2024 02:49
@jonathan-innis jonathan-innis marked this pull request as ready for review May 14, 2024 02:49
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 14, 2024
@jonathan-innis jonathan-innis force-pushed the no-require-nodeclaim-condition-status branch from 53afec4 to 3a73163 Compare May 14, 2024 02:54
@jonathan-innis jonathan-innis changed the title chore: Don't require message or reason to be set for NodeClaims chore: Don't require message or reason to be set for NodeClaim May 14, 2024
@jonathan-innis jonathan-innis changed the title chore: Don't require message or reason to be set for NodeClaim chore: Don't require message or reason to be set for NodeClaim status conditions May 14, 2024
@jonathan-innis jonathan-innis force-pushed the no-require-nodeclaim-condition-status branch 3 times, most recently from e1b255c to 05deb0f Compare May 14, 2024 19:56
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 14, 2024
@jonathan-innis jonathan-innis force-pushed the no-require-nodeclaim-condition-status branch from 05deb0f to 6f20f8d Compare May 14, 2024 19:58
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 14, 2024
@jonathan-innis jonathan-innis force-pushed the no-require-nodeclaim-condition-status branch from 6f20f8d to 4729c53 Compare May 14, 2024 19:58
@k8s-ci-robot k8s-ci-robot removed the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 14, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 14, 2024
@jonathan-innis jonathan-innis force-pushed the no-require-nodeclaim-condition-status branch 3 times, most recently from c82d74a to 83f847a Compare May 14, 2024 20:10
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 14, 2024
@jonathan-innis jonathan-innis force-pushed the no-require-nodeclaim-condition-status branch from 83f847a to b9f4a0e Compare May 14, 2024 20:11
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 14, 2024
Copy link
Contributor

@njtran njtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 14, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jonathan-innis, njtran

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jonathan-innis,njtran]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4a21b45 into kubernetes-sigs:main May 14, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants