Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add deletiontimestamp check for kwok termination #1322

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

njtran
Copy link
Contributor

@njtran njtran commented Jun 14, 2024

Fixes #N/A

Description
Karpenter now waits for the nodeclaim to be not found with the cloudprovider.Get() call, which this implements the fix for the kwok cloud provider

How was this change tested?
make apply

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 14, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: njtran

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 14, 2024
@coveralls
Copy link

coveralls commented Jun 14, 2024

Pull Request Test Coverage Report for Build 9522926993

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.03%) to 81.297%

Files with Coverage Reduction New Missed Lines %
pkg/controllers/disruption/drift.go 2 89.29%
pkg/controllers/node/termination/terminator/eviction.go 2 89.09%
Totals Coverage Status
Change from base Build 9492890501: 0.03%
Covered Lines: 8302
Relevant Lines: 10212

💛 - Coveralls

@jmdeal
Copy link
Member

jmdeal commented Jun 14, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 14, 2024
@k8s-ci-robot k8s-ci-robot merged commit b350b58 into kubernetes-sigs:main Jun 14, 2024
13 checks passed
@njtran njtran deleted the kwoktermination branch June 14, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants