Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add test timestamp collector #1324

Merged
merged 7 commits into from
Jun 18, 2024
Merged

test: add test timestamp collector #1324

merged 7 commits into from
Jun 18, 2024

Conversation

njtran
Copy link
Contributor

@njtran njtran commented Jun 17, 2024

Fixes #N/A

Description
Adds a Collector that automatically collects and prints timestamps of the tests to a temporary csv directory.

How was this change tested?
make apply && make e2etests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 17, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 17, 2024
@coveralls
Copy link

coveralls commented Jun 17, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9552861421

Details

  • 0 of 99 (0.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.7%) to 80.555%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/test/pods.go 0 99 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/controllers/disruption/drift.go 2 89.29%
Totals Coverage Status
Change from base Build 9524137760: -0.7%
Covered Lines: 8306
Relevant Lines: 10311
💛 - Coveralls

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 17, 2024
@coveralls
Copy link

coveralls commented Jun 17, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9554102843

Details

  • 0 of 99 (0.0%) changed or added relevant lines in 1 file are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.8%) to 80.487%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/test/pods.go 0 99 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/controllers/provisioning/scheduling/preferences.go 7 86.67%
Totals Coverage Status
Change from base Build 9524137760: -0.8%
Covered Lines: 8299
Relevant Lines: 10311
💛 - Coveralls

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 17, 2024
njtran
njtran commented Jun 17, 2024
View reviewed changes
test/suites/perf/suite_test.go
Comment on lines +68 to +74
test.ReplaceRequirements(nodePool, v1beta1.NodeSelectorRequirementWithMinValues{
NodeSelectorRequirement: v1.NodeSelectorRequirement{
Key: v1alpha1.InstanceSizeLabelKey,
Operator: v1.NodeSelectorOpLt,
Values: []string{"32"},
},
})
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added this so that we just have a lower instance size and get multiple nodes on simple scale ups.

@coveralls
Copy link

coveralls commented Jun 17, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9554569249

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 99 (0.0%) changed or added relevant lines in 1 file are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.7%) to 80.535%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/test/pods.go 0 99 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/controllers/disruption/drift.go 2 89.29%
pkg/controllers/disruption/expiration.go 2 89.66%
Totals Coverage Status
Change from base Build 9554558179: -0.7%
Covered Lines: 8304
Relevant Lines: 10311
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 17, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9554615976

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 99 (0.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.8%) to 80.506%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/test/pods.go 0 99 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/controllers/disruption/drift.go 2 89.29%
Totals Coverage Status
Change from base Build 9554558179: -0.8%
Covered Lines: 8301
Relevant Lines: 10311
💛 - Coveralls

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 18, 2024
@coveralls
Copy link

coveralls commented Jun 18, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9569212809

Details

  • 0 of 99 (0.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.8%) to 80.507%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/test/pods.go 0 99 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/controllers/disruption/drift.go 2 89.29%
Totals Coverage Status
Change from base Build 9557334180: -0.8%
Covered Lines: 8322
Relevant Lines: 10337
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 18, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9569558342

Details

  • 0 of 99 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.8%) to 80.526%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/test/pods.go 0 99 0.0%
Totals Coverage Status
Change from base Build 9557334180: -0.8%
Covered Lines: 8324
Relevant Lines: 10337
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 18, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9569727702

Details

  • 0 of 99 (0.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.8%) to 80.507%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/test/pods.go 0 99 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/controllers/provisioning/scheduling/nodeclaim.go 2 89.13%
Totals Coverage Status
Change from base Build 9557334180: -0.8%
Covered Lines: 8322
Relevant Lines: 10337
💛 - Coveralls

jonathan-innis
jonathan-innis approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 18, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jonathan-innis, njtran

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jonathan-innis,njtran]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e58d48e into kubernetes-sigs:main Jun 18, 2024
13 checks passed
@njtran njtran deleted the checkPodTimes branch June 18, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-innis jonathan-innis jonathan-innis approved these changes

@jmdeal jmdeal Awaiting requested review from jmdeal

@tallaxes tallaxes Awaiting requested review from tallaxes

Assignees

@jonathan-innis jonathan-innis

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@njtran @coveralls @k8s-ci-robot @jonathan-innis