feat: Add Conversion Webhooks for V1 APIs

[engedaam]

Fixes #N/A

Description

• Add Conversion webhook APIs for NodePool and NodeClaims

How was this change tested?

• make presubmit

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[k8s-ci-robot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[coveralls]

Pull Request Test Coverage Report for Build 9687450759

Details

• 271 of 338 (80.18%) changed or added relevant lines in 9 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.7%) to 78.962%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/apis/v1beta1/nodeclaim_conversion.go	0	2	0.0%
pkg/apis/v1beta1/nodepool_conversion.go	0	2	0.0%
pkg/operator/injection/injection.go	14	18	77.78%
pkg/operator/operator.go	0	4	0.0%
pkg/apis/v1/nodepool_conversion.go	120	130	92.31%
pkg/webhooks/webhooks.go	0	10	0.0%
pkg/apis/v1/zz_generated.deepcopy.go	16	33	48.48%
pkg/apis/v1/nodeclaim_conversion.go	117	135	86.67%

Totals
Change from base Build 9687383593:	0.7%
Covered Lines:	8903
Relevant Lines:	11275

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 9687470480

Details

• 271 of 338 (80.18%) changed or added relevant lines in 9 files are covered.
• 6 unchanged lines in 3 files lost coverage.
• Overall coverage increased (+0.7%) to 78.971%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/apis/v1beta1/nodeclaim_conversion.go	0	2	0.0%
pkg/apis/v1beta1/nodepool_conversion.go	0	2	0.0%
pkg/operator/injection/injection.go	14	18	77.78%
pkg/operator/operator.go	0	4	0.0%
pkg/apis/v1/nodepool_conversion.go	120	130	92.31%
pkg/webhooks/webhooks.go	0	10	0.0%
pkg/apis/v1/zz_generated.deepcopy.go	16	33	48.48%
pkg/apis/v1/nodeclaim_conversion.go	117	135	86.67%

Files with Coverage Reduction	New Missed Lines	%
pkg/controllers/disruption/drift.go	2	89.09%
pkg/scheduling/requirements.go	2	98.01%
pkg/controllers/node/termination/terminator/eviction.go	2	89.09%

Totals
Change from base Build 9687383593:	0.7%
Covered Lines:	8904
Relevant Lines:	11275

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 9746470447

Details

• 242 of 272 (88.97%) changed or added relevant lines in 7 files are covered.
• 13 unchanged lines in 3 files lost coverage.
• Overall coverage increased (+0.3%) to 79.123%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/apis/v1beta1/nodeclaim_conversion.go	0	2	0.0%
pkg/apis/v1beta1/nodepool_conversion.go	0	2	0.0%
pkg/operator/injection/injection.go	14	18	77.78%
pkg/operator/operator.go	0	4	0.0%
pkg/apis/v1/nodeclaim_conversion.go	112	120	93.33%
pkg/webhooks/webhooks.go	0	10	0.0%

Files with Coverage Reduction	New Missed Lines	%
pkg/test/expectations/expectations.go	2	93.69%
pkg/controllers/node/termination/controller.go	2	59.81%
pkg/webhooks/webhooks.go	9	0.0%

Totals
Change from base Build 9721804824:	0.3%
Covered Lines:	8842
Relevant Lines:	11175

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 9746484102

Details

• 242 of 272 (88.97%) changed or added relevant lines in 7 files are covered.
• 9 unchanged lines in 2 files lost coverage.
• Overall coverage increased (+0.3%) to 79.078%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/apis/v1beta1/nodeclaim_conversion.go	0	2	0.0%
pkg/apis/v1beta1/nodepool_conversion.go	0	2	0.0%
pkg/operator/injection/injection.go	14	18	77.78%
pkg/operator/operator.go	0	4	0.0%
pkg/apis/v1/nodeclaim_conversion.go	112	120	93.33%
pkg/webhooks/webhooks.go	0	10	0.0%

Files with Coverage Reduction	New Missed Lines	%
pkg/controllers/node/termination/controller.go	2	59.81%
pkg/controllers/provisioning/scheduling/preferences.go	7	86.67%

Totals
Change from base Build 9721804824:	0.3%
Covered Lines:	8837
Relevant Lines:	11175

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 9746527988

Details

• 242 of 272 (88.97%) changed or added relevant lines in 7 files are covered.
• 4 unchanged lines in 2 files lost coverage.
• Overall coverage increased (+0.3%) to 79.123%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/apis/v1beta1/nodeclaim_conversion.go	0	2	0.0%
pkg/apis/v1beta1/nodepool_conversion.go	0	2	0.0%
pkg/operator/injection/injection.go	14	18	77.78%
pkg/operator/operator.go	0	4	0.0%
pkg/apis/v1/nodeclaim_conversion.go	112	120	93.33%
pkg/webhooks/webhooks.go	0	10	0.0%

Files with Coverage Reduction	New Missed Lines	%
pkg/test/expectations/expectations.go	2	93.69%
pkg/controllers/node/termination/controller.go	2	59.81%

Totals
Change from base Build 9721804824:	0.3%
Covered Lines:	8842
Relevant Lines:	11175

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 9782771807

Details

• 242 of 272 (88.97%) changed or added relevant lines in 7 files are covered.
• 2 unchanged lines in 1 file lost coverage.
• Overall coverage increased (+0.3%) to 79.092%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/apis/v1beta1/nodeclaim_conversion.go	0	2	0.0%
pkg/apis/v1beta1/nodepool_conversion.go	0	2	0.0%
pkg/operator/injection/injection.go	14	18	77.78%
pkg/operator/operator.go	0	4	0.0%
pkg/apis/v1/nodeclaim_conversion.go	112	120	93.33%
pkg/webhooks/webhooks.go	0	10	0.0%

Files with Coverage Reduction	New Missed Lines	%
pkg/test/expectations/expectations.go	2	93.69%

Totals
Change from base Build 9772878439:	0.3%
Covered Lines:	8852
Relevant Lines:	11192

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 9784730774

Details

• 195 of 225 (86.67%) changed or added relevant lines in 7 files are covered.
• 2 unchanged lines in 1 file lost coverage.
• Overall coverage increased (+0.2%) to 78.959%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/apis/v1/nodeclaim_conversion.go	79	81	97.53%
pkg/apis/v1beta1/nodeclaim_conversion.go	0	2	0.0%
pkg/apis/v1beta1/nodepool_conversion.go	0	2	0.0%
pkg/operator/injection/injection.go	7	9	77.78%
pkg/operator/operator.go	0	3	0.0%
pkg/apis/v1/nodepool_conversion.go	109	118	92.37%
pkg/webhooks/webhooks.go	0	10	0.0%

Files with Coverage Reduction	New Missed Lines	%
pkg/controllers/node/termination/terminator/eviction.go	2	89.09%

Totals
Change from base Build 9772878439:	0.2%
Covered Lines:	8800
Relevant Lines:	11145

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 9784823970

Details

• 195 of 225 (86.67%) changed or added relevant lines in 7 files are covered.
• 13 unchanged lines in 3 files lost coverage.
• Overall coverage increased (+0.2%) to 78.923%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/apis/v1/nodeclaim_conversion.go	79	81	97.53%
pkg/apis/v1beta1/nodeclaim_conversion.go	0	2	0.0%
pkg/apis/v1beta1/nodepool_conversion.go	0	2	0.0%
pkg/operator/injection/injection.go	7	9	77.78%
pkg/operator/operator.go	0	3	0.0%
pkg/apis/v1/nodepool_conversion.go	109	118	92.37%
pkg/webhooks/webhooks.go	0	10	0.0%

Files with Coverage Reduction	New Missed Lines	%
pkg/test/expectations/expectations.go	2	93.69%
pkg/controllers/node/termination/terminator/eviction.go	2	89.09%
pkg/webhooks/webhooks.go	9	0.0%

Totals
Change from base Build 9772878439:	0.2%
Covered Lines:	8796
Relevant Lines:	11145

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 9784920257

Details

• 195 of 225 (86.67%) changed or added relevant lines in 7 files are covered.
• 2 unchanged lines in 1 file lost coverage.
• Overall coverage increased (+0.2%) to 78.941%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/apis/v1/nodeclaim_conversion.go	79	81	97.53%
pkg/apis/v1beta1/nodeclaim_conversion.go	0	2	0.0%
pkg/apis/v1beta1/nodepool_conversion.go	0	2	0.0%
pkg/operator/injection/injection.go	7	9	77.78%
pkg/operator/operator.go	0	3	0.0%
pkg/apis/v1/nodepool_conversion.go	109	118	92.37%
pkg/webhooks/webhooks.go	0	10	0.0%

Files with Coverage Reduction	New Missed Lines	%
pkg/controllers/disruption/drift.go	2	89.09%

Totals
Change from base Build 9772878439:	0.2%
Covered Lines:	8798
Relevant Lines:	11145

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 9785588418

Details

• 193 of 224 (86.16%) changed or added relevant lines in 7 files are covered.
• 7 unchanged lines in 1 file lost coverage.
• Overall coverage increased (+0.1%) to 78.885%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/apis/v1/nodeclaim_conversion.go	79	81	97.53%
pkg/apis/v1beta1/nodeclaim_conversion.go	0	2	0.0%
pkg/apis/v1beta1/nodepool_conversion.go	0	2	0.0%
pkg/operator/injection/injection.go	7	10	70.0%
pkg/operator/operator.go	0	3	0.0%
pkg/apis/v1/nodepool_conversion.go	107	116	92.24%
pkg/webhooks/webhooks.go	0	10	0.0%

Files with Coverage Reduction	New Missed Lines	%
pkg/controllers/provisioning/scheduling/preferences.go	7	86.67%

Totals
Change from base Build 9772878439:	0.1%
Covered Lines:	8791
Relevant Lines:	11144

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 9785718428

Details

• 187 of 220 (85.0%) changed or added relevant lines in 7 files are covered.
• 2 unchanged lines in 1 file lost coverage.
• Overall coverage increased (+0.2%) to 78.923%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/apis/v1/nodeclaim_conversion.go	79	81	97.53%
pkg/apis/v1beta1/nodeclaim_conversion.go	0	2	0.0%
pkg/apis/v1beta1/nodepool_conversion.go	0	2	0.0%
pkg/operator/injection/injection.go	7	10	70.0%
pkg/operator/operator.go	0	3	0.0%
pkg/webhooks/webhooks.go	0	10	0.0%
pkg/apis/v1/nodepool_conversion.go	101	112	90.18%

Files with Coverage Reduction	New Missed Lines	%
pkg/controllers/disruption/drift.go	2	89.09%

Totals
Change from base Build 9772878439:	0.2%
Covered Lines:	8792
Relevant Lines:	11140

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 9786007465

Details

• 187 of 220 (85.0%) changed or added relevant lines in 7 files are covered.
• 9 unchanged lines in 2 files lost coverage.
• Overall coverage increased (+0.1%) to 78.86%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/apis/v1/nodeclaim_conversion.go	79	81	97.53%
pkg/apis/v1beta1/nodeclaim_conversion.go	0	2	0.0%
pkg/apis/v1beta1/nodepool_conversion.go	0	2	0.0%
pkg/operator/injection/injection.go	7	10	70.0%
pkg/operator/operator.go	0	3	0.0%
pkg/webhooks/webhooks.go	0	10	0.0%
pkg/apis/v1/nodepool_conversion.go	101	112	90.18%

Files with Coverage Reduction	New Missed Lines	%
pkg/controllers/disruption/drift.go	2	89.09%
pkg/controllers/provisioning/scheduling/preferences.go	7	86.67%

Totals
Change from base Build 9772878439:	0.1%
Covered Lines:	8785
Relevant Lines:	11140

---

💛 - Coveralls

[njtran]

/lgtm
/approve

[coveralls]

Pull Request Test Coverage Report for Build 9786124945

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 189 of 222 (85.14%) changed or added relevant lines in 7 files are covered.
• 9 unchanged lines in 2 files lost coverage.
• Overall coverage increased (+0.1%) to 78.864%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/apis/v1/nodeclaim_conversion.go	79	81	97.53%
pkg/apis/v1beta1/nodeclaim_conversion.go	0	2	0.0%
pkg/apis/v1beta1/nodepool_conversion.go	0	2	0.0%
pkg/operator/injection/injection.go	7	10	70.0%
pkg/operator/operator.go	0	3	0.0%
pkg/webhooks/webhooks.go	0	10	0.0%
pkg/apis/v1/nodepool_conversion.go	103	114	90.35%

Files with Coverage Reduction	New Missed Lines	%
pkg/test/expectations/expectations.go	2	93.69%
pkg/controllers/provisioning/scheduling/preferences.go	7	86.67%

Totals
Change from base Build 9772878439:	0.1%
Covered Lines:	8787
Relevant Lines:	11142

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 9786712933

Details

• 189 of 222 (85.14%) changed or added relevant lines in 7 files are covered.
• 2 unchanged lines in 1 file lost coverage.
• Overall coverage increased (+0.2%) to 78.824%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/apis/v1/nodeclaim_conversion.go	79	81	97.53%
pkg/apis/v1beta1/nodeclaim_conversion.go	0	2	0.0%
pkg/apis/v1beta1/nodepool_conversion.go	0	2	0.0%
pkg/operator/injection/injection.go	7	10	70.0%
pkg/operator/operator.go	0	3	0.0%
pkg/webhooks/webhooks.go	0	10	0.0%
pkg/apis/v1/nodepool_conversion.go	103	114	90.35%

Files with Coverage Reduction	New Missed Lines	%
pkg/scheduling/requirements.go	2	98.01%

Totals
Change from base Build 9786565889:	0.2%
Covered Lines:	8863
Relevant Lines:	11244

---

💛 - Coveralls

[njtran]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: engedaam, njtran

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [njtran]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment