Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Migrate Machine to v1alpha5 API #143

Merged
merged 2 commits into from
Dec 29, 2022
Merged

chore: Migrate Machine to v1alpha5 API #143

merged 2 commits into from
Dec 29, 2022

Conversation

jonathan-innis
Copy link
Member

@jonathan-innis jonathan-innis commented Dec 28, 2022 •
edited
Loading

Fixes #

Description

  • Migrate Machine to v1alpha5 so that all related apis in the group are at the same version

How was this change tested?

make presubmit

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner December 28, 2022 23:07
@coveralls
Copy link

coveralls commented Dec 28, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3798268632

  • 43 of 204 (21.08%) changed or added relevant lines in 10 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.4%) to 77.196%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cloudprovider/fake/cloudprovider.go 3 4 75.0%
pkg/cloudprovider/metrics/cloudprovider.go 0 2 0.0%
pkg/cloudprovider/types.go 0 11 0.0%
pkg/test/machine.go 0 13 0.0%
pkg/utils/machine/machine.go 25 38 65.79%
pkg/apis/v1alpha5/zz_generated.deepcopy.go 0 121 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/controllers/deprovisioning/controller.go 2 70.81%
Totals Coverage Status
Change from base Build 3746274074: -0.4%
Covered Lines: 5704
Relevant Lines: 7389
💛 - Coveralls

@jonathan-innis jonathan-innis force-pushed the helper-funcs branch 5 times, most recently from 8fb06c3 to 2b03f70 Compare December 28, 2022 23:48
@jonathan-innis jonathan-innis enabled auto-merge (squash) December 28, 2022 23:49
@jonathan-innis jonathan-innis marked this pull request as draft December 28, 2022 23:50
auto-merge was automatically disabled December 28, 2022 23:50

Pull request was converted to draft

@jonathan-innis jonathan-innis marked this pull request as ready for review December 28, 2022 23:50
@jonathan-innis jonathan-innis force-pushed the helper-funcs branch 2 times, most recently from eb69b52 to 1276ad9 Compare December 28, 2022 23:53
ellistarn
ellistarn reviewed Dec 29, 2022
View reviewed changes
pkg/apis/v1alpha1/machine.go Outdated Show resolved Hide resolved
pkg/apis/v1alpha5/provisioner.go Outdated Show resolved Hide resolved
pkg/controllers/provisioning/scheduling/machinetemplate.go Outdated Show resolved Hide resolved
@jonathan-innis jonathan-innis changed the title chore: Add helper funcs and methods for adoption controller chore: Migrate Machine to v1alpha5 API Dec 29, 2022
@jonathan-innis jonathan-innis enabled auto-merge (squash) December 29, 2022 04:28
@jonathan-innis jonathan-innis merged commit 9b38f8c into kubernetes-sigs:main Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellistarn ellistarn ellistarn approved these changes

@bwagner5 bwagner5 Awaiting requested review from bwagner5 bwagner5 was automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonathan-innis @coveralls @ellistarn