Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix README build status badge #147

Merged
merged 1 commit into from
Jan 3, 2023
Merged

docs: Fix README build status badge #147

merged 1 commit into from
Jan 3, 2023

Conversation

jonathan-innis
Copy link
Member

Fixes #

Description

  • Fix README build status badge

How was this change tested?

  • Viewing the status badge on the README in the fork

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner January 2, 2023 05:12
@jonathan-innis jonathan-innis force-pushed the fix-badge branch 6 times, most recently from 9031579 to 640bd96 Compare January 2, 2023 05:21
@jonathan-innis jonathan-innis enabled auto-merge (squash) January 2, 2023 05:22
@coveralls
Copy link

coveralls commented Jan 2, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 3820468939

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 12 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.07%) to 76.065%
Files with Coverage Reduction New Missed Lines %
pkg/controllers/deprovisioning/controller.go 3 70.33%
pkg/controllers/deprovisioning/events/events.go 9 80.0%
Totals Coverage Status
Change from base Build 3808892891: -0.07%
Covered Lines: 5714
Relevant Lines: 7512
💛 - Coveralls

bwagner5
bwagner5 approved these changes Jan 3, 2023
View reviewed changes
Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathan-innis jonathan-innis merged commit 1fd0f13 into kubernetes-sigs:main Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwagner5 bwagner5 bwagner5 approved these changes

@njtran njtran Awaiting requested review from njtran njtran was automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonathan-innis @coveralls @bwagner5