Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Fix MachineNotFound custom error type checking #148

Merged
merged 2 commits into from
Jan 3, 2023
Merged

chore: Fix MachineNotFound custom error type checking #148

merged 2 commits into from
Jan 3, 2023

Conversation

jonathan-innis
Copy link
Member

@jonathan-innis jonathan-innis commented Jan 3, 2023 •
edited
Loading

Fixes #

Description

  • Fix MachineNotFound custom error type checking
  • Updates the type appropriately since errors.As does not perform correctly when simply typing errors with cloudprovider.MachineNotFoundError(err)

This is a similar change to aws/karpenter-provider-aws#2253

How was this change tested?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner January 3, 2023 01:02
@coveralls
Copy link

coveralls commented Jan 3, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 3831301829

  • 0 of 9 (0.0%) changed or added relevant lines in 1 file are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 75.957%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cloudprovider/types.go 0 9 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/controllers/provisioning/scheduling/preferences.go 7 86.67%
Totals Coverage Status
Change from base Build 3830896045: -0.1%
Covered Lines: 5712
Relevant Lines: 7520
💛 - Coveralls

bwagner5
bwagner5 reviewed Jan 3, 2023
View reviewed changes
pkg/cloudprovider/types.go Outdated Show resolved Hide resolved
@jonathan-innis jonathan-innis enabled auto-merge (squash) January 3, 2023 15:57
bwagner5
bwagner5 approved these changes Jan 3, 2023
View reviewed changes
Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathan-innis jonathan-innis merged commit 78364b2 into kubernetes-sigs:main Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwagner5 bwagner5 bwagner5 approved these changes

@engedaam engedaam Awaiting requested review from engedaam engedaam was automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonathan-innis @coveralls @bwagner5