Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add v1 APIs for v0.34.x #1485

Merged

Conversation

engedaam
Copy link
Contributor

@engedaam engedaam commented Jul 30, 2024

Fixes #N/A

Description

  • Add v1 APIs
  • This is a copy and from main to release a patch version of 0.34

How was this change tested?

  • make presubmit

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 30, 2024
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 30, 2024
@engedaam engedaam force-pushed the add-v1-rollback-34 branch 2 times, most recently from 663d78b to d250c75 Compare July 31, 2024 00:31
@engedaam engedaam changed the title chore: Add v1 APIs for the v0.34.x breach chore: Add v1 APIs for the v0.34.x Jul 31, 2024
@engedaam engedaam changed the title chore: Add v1 APIs for the v0.34.x chore: Add v1 APIs for v0.34.x Jul 31, 2024
@engedaam engedaam force-pushed the add-v1-rollback-34 branch 4 times, most recently from 80153db to f280e71 Compare July 31, 2024 02:58
Copy link
Contributor

@njtran njtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: engedaam, njtran

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 31, 2024
@k8s-ci-robot k8s-ci-robot merged commit ad721f7 into kubernetes-sigs:release-v0.34.x Jul 31, 2024
12 checks passed
@engedaam engedaam deleted the add-v1-rollback-34 branch August 26, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants