Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix log line on consistency errors #1511

Merged
merged 1 commit into from
Aug 5, 2024
Merged

fix: fix log line on consistency errors #1511

merged 1 commit into from
Aug 5, 2024

Conversation

njtran
Copy link
Contributor

@njtran njtran commented Aug 5, 2024

Fixes #1498

Description
Fixes the lack of information on consistency failures

How was this change tested?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 5, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10253713696

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 77.89%
Files with Coverage Reduction New Missed Lines %
pkg/controllers/disruption/consolidation.go 4 87.25%
Totals Coverage Status
Change from base Build 10222210502: -0.04%
Covered Lines: 8895
Relevant Lines: 11420
💛 - Coveralls

@jmdeal
Copy link
Member

jmdeal commented Aug 5, 2024

/lgtm

jigisha620
jigisha620 approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@jigisha620 jigisha620 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 5, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jigisha620, njtran

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 1a0ecd5 into kubernetes-sigs:main Aug 5, 2024
11 checks passed
@njtran njtran deleted the logline branch August 5, 2024 18:23
BEvgeniyS pushed a commit to BEvgeniyS/karpenter that referenced this pull request Sep 16, 2024
@njtran @BEvgeniyS
fix: fix log line on consistency errors (kubernetes-sigs#1511)
b106e45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jigisha620 jigisha620 jigisha620 approved these changes

@engedaam engedaam Awaiting requested review from engedaam

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

Assignees

@jmdeal jmdeal

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unclear log line during forceful node deletion
5 participants
@njtran @coveralls @jmdeal @k8s-ci-robot @jigisha620