Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix missed return statement in cluster.State Capacity #156

Merged
merged 2 commits into from
Jan 9, 2023
Merged

fix: Fix missed return statement in cluster.State Capacity #156

merged 2 commits into from
Jan 9, 2023

Conversation

jonathan-innis
Copy link
Member

@jonathan-innis jonathan-innis commented Jan 7, 2023 •
edited
Loading

Fixes #

Description

  • Fix missed return statement in cluster.State Capacity
  • Fix incorrect capturing of remainingResources

How was this change tested?

make presubmit

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner January 7, 2023 00:29
@jonathan-innis jonathan-innis enabled auto-merge (squash) January 7, 2023 00:34
@coveralls
Copy link

coveralls commented Jan 7, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 3876420121

  • 9 of 9 (100.0%) changed or added relevant lines in 3 files are covered.
  • 19 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.02%) to 76.402%
Files with Coverage Reduction New Missed Lines %
pkg/controllers/deprovisioning/controller.go 3 70.33%
pkg/controllers/node/controller.go 7 74.19%
pkg/controllers/deprovisioning/events/events.go 9 80.0%
Totals Coverage Status
Change from base Build 3857342106: 0.02%
Covered Lines: 5792
Relevant Lines: 7581
💛 - Coveralls

tzneal
tzneal approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@tzneal tzneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jonathan-innis jonathan-innis merged commit f2e24dc into kubernetes-sigs:main Jan 9, 2023
@jonathan-innis jonathan-innis deleted the cluster-state-fix branch January 9, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzneal tzneal tzneal approved these changes

@spring1843 spring1843 Awaiting requested review from spring1843 spring1843 was automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonathan-innis @coveralls @tzneal