Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update max delay for NodeClaim lifecycle controller #1561

Merged

Conversation

rschalo
Copy link
Contributor

@rschalo rschalo commented Aug 12, 2024

Fixes #N/A

Description
Updates the max delay of the NodeClaim lifecycle controller such that the request exponentially backs off through NodeClaim expiration if the NodeClaim fails to register.

How was this change tested?
make presubmit

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 12, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @rschalo. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 12, 2024
Copy link
Contributor

@njtran njtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 12, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: njtran, rschalo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10356816435

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 11 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.08%) to 77.821%

Files with Coverage Reduction New Missed Lines %
pkg/controllers/disruption/drift.go 2 89.66%
pkg/controllers/node/termination/controller.go 2 66.47%
pkg/controllers/provisioning/scheduling/preferences.go 7 86.67%
Totals Coverage Status
Change from base Build 10356232352: -0.08%
Covered Lines: 8916
Relevant Lines: 11457

💛 - Coveralls

@k8s-ci-robot k8s-ci-robot merged commit 92547d1 into kubernetes-sigs:main Aug 12, 2024
11 checks passed
rschalo added a commit to rschalo/karpenter that referenced this pull request Aug 12, 2024
rschalo added a commit to rschalo/karpenter that referenced this pull request Aug 12, 2024
rschalo added a commit to rschalo/karpenter that referenced this pull request Aug 12, 2024
rschalo added a commit to rschalo/karpenter that referenced this pull request Aug 12, 2024
rschalo added a commit to rschalo/karpenter that referenced this pull request Aug 12, 2024
k8s-ci-robot pushed a commit that referenced this pull request Aug 12, 2024
k8s-ci-robot pushed a commit that referenced this pull request Aug 12, 2024
k8s-ci-robot pushed a commit that referenced this pull request Aug 12, 2024
k8s-ci-robot pushed a commit that referenced this pull request Aug 12, 2024
k8s-ci-robot pushed a commit that referenced this pull request Aug 12, 2024
BEvgeniyS pushed a commit to BEvgeniyS/karpenter that referenced this pull request Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants