Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Return a machine struct from the cloudprovider create call #164

Merged

Conversation

jonathan-innis
Copy link
Member

Fixes #

Description

  • Return a v1alpha5.Machine struct from the cloudprovider create call
  • This change preps for the machine.Controller which will use the full response to update the Machine status

How was this change tested?

make test

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@coveralls
Copy link

coveralls commented Jan 18, 2023

Pull Request Test Coverage Report for Build 3946578529

  • 25 of 32 (78.13%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.6%) to 76.909%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cloudprovider/fake/cloudprovider.go 8 10 80.0%
pkg/cloudprovider/metrics/cloudprovider.go 0 5 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/cloudprovider/fake/cloudprovider.go 1 94.5%
Totals Coverage Status
Change from base Build 3888407071: 0.6%
Covered Lines: 5822
Relevant Lines: 7570

💛 - Coveralls

@jonathan-innis jonathan-innis merged commit 12c3355 into kubernetes-sigs:main Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants