Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Fix cache syncing causing transient failures #188

Merged
merged 1 commit into from
Jan 31, 2023
Merged

test: Fix cache syncing causing transient failures #188

merged 1 commit into from
Jan 31, 2023

Conversation

jonathan-innis
Copy link
Member

Fixes #

Description

  • Fix cache syncing causing transient failures
  • Cache syncing was updating the pointer when it would try to re-get the object, so, in reality, the syncing portion of the client would only attempt to get the updated object twice

How was this change tested?

make presubmit

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner January 31, 2023 01:47
@jonathan-innis jonathan-innis enabled auto-merge (squash) January 31, 2023 01:49
@coveralls
Copy link

coveralls commented Jan 31, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4049926553

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 79.321%
Files with Coverage Reduction New Missed Lines %
pkg/test/cachesyncingclient.go 2 73.91%
Totals Coverage Status
Change from base Build 4048959812: -0.1%
Covered Lines: 6402
Relevant Lines: 8071
💛 - Coveralls

@jonathan-innis jonathan-innis merged commit 53e783d into kubernetes-sigs:main Jan 31, 2023
@jonathan-innis jonathan-innis deleted the fix-cache-syncing branch January 31, 2023 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amanueng amanueng amanueng approved these changes

@engedaam engedaam engedaam approved these changes

@njtran njtran Awaiting requested review from njtran njtran was automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jonathan-innis @coveralls @amanueng @engedaam