Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Create a garbage collection reconciler for v1alpha5.Machine #202

Merged
merged 2 commits into from
Feb 10, 2023
Merged

chore: Create a garbage collection reconciler for v1alpha5.Machine #202

merged 2 commits into from
Feb 10, 2023

Conversation

jonathan-innis
Copy link
Member

@jonathan-innis jonathan-innis commented Feb 3, 2023 •
edited
Loading

Fixes #

Description

  • Create a garbage collection reconciler for v1alpha5.Machine
  • Re-organizes sub-reconciler testing into separate files

How was this change tested?

make presubmit

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis changed the title chore: Create a garbage collection reconciler for machine chore: Create a garbage collection reconciler for v1alpha5.Machine Feb 3, 2023
@jonathan-innis jonathan-innis marked this pull request as ready for review February 3, 2023 23:38
@jonathan-innis jonathan-innis requested a review from a team as a code owner February 3, 2023 23:38
@jonathan-innis jonathan-innis force-pushed the existence-sub-reconciler branch 4 times, most recently from e4216d1 to 78a1519 Compare February 4, 2023 00:28
@coveralls
Copy link

coveralls commented Feb 4, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4148357710

  • 22 of 24 (91.67%) changed or added relevant lines in 5 files are covered.
  • 8 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.01%) to 78.427%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controllers/machine/initialization.go 1 3 33.33%
Files with Coverage Reduction New Missed Lines %
pkg/controllers/machine/liveness.go 1 90.0%
pkg/controllers/provisioning/scheduling/preferences.go 7 86.67%
Totals Coverage Status
Change from base Build 4148281086: 0.01%
Covered Lines: 6293
Relevant Lines: 8024
💛 - Coveralls

bwagner5
bwagner5 previously approved these changes Feb 10, 2023
View reviewed changes
Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bwagner5
bwagner5 approved these changes Feb 10, 2023
View reviewed changes
Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathan-innis jonathan-innis enabled auto-merge (squash) February 10, 2023 23:18
@jonathan-innis jonathan-innis merged commit 874ad56 into kubernetes-sigs:main Feb 10, 2023
@jonathan-innis jonathan-innis deleted the existence-sub-reconciler branch February 10, 2023 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwagner5 bwagner5 bwagner5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonathan-innis @coveralls @bwagner5