chore: Stage core changes for linking machines (migration) #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-innis
force-pushed
the
machine-link-controller
branch
2 times, most recently
from
4591c83
to
bd53698
Compare
Pull Request Test Coverage Report for Build 4176835870
💛 - Coveralls |
jonathan-innis
force-pushed
the
machine-link-controller
branch
4 times, most recently
from
25ec991
to
2013019
Compare
bwagner5
previously approved these changes
Feb 14, 2023
jonathan-innis
force-pushed
the
machine-link-controller
branch
from
2013019
to
eba929c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Description
Stages out karpenter-core changes for linking machines to a backing cloudprovider instance by using a
karpenter.sh/linkedannotation on the Machine to tell the machine controller to link the machine instead of launching a new oneHow was this change tested?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.