chore: Truncate instance types requirements list #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-innis
force-pushed
the
truncate-instance-types
branch
from
0e1be4f
to
e458ce3
Compare
Pull Request Test Coverage Report for Build 4187620823
💛 - Coveralls |
ellistarn
reviewed
Feb 14, 2023
njtran
previously approved these changes
Feb 15, 2023
jonathan-innis
force-pushed
the
truncate-instance-types
branch
from
e458ce3
to
df4d72e
Compare
njtran
approved these changes
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Description
Truncates the instance types requirements list so that the list will not be too large when it is populated into the
v1alpha5.Machinespec. This list is now truncated down to the top 200 instance types that match the requirements. Cloudprovider are obviously welcome to further truncate this list down more if they need for their requests.How was this change tested?
make presubmitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.