Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Bump go to 1.20 #215

Merged
merged 1 commit into from
Feb 17, 2023
Merged

chore: Bump go to 1.20 #215

merged 1 commit into from
Feb 17, 2023

Conversation

jonathan-innis
Copy link
Member

Fixes #

Description

Bump go to 1.20

How was this change tested?

make presubmit

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner February 16, 2023 23:10
bwagner5
bwagner5 reviewed Feb 16, 2023
View reviewed changes
Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you update test/ too?

bwagner5
bwagner5 previously approved these changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

coveralls commented Feb 16, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4199174531

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+2.6%) to 81.17%
Files with Coverage Reduction New Missed Lines %
pkg/metrics/metrics.go 3 0%
Totals Coverage Status
Change from base Build 4189058856: 2.6%
Covered Lines: 6367
Relevant Lines: 7844
💛 - Coveralls

bwagner5
bwagner5 previously approved these changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathan-innis jonathan-innis enabled auto-merge (squash) February 16, 2023 23:38
bwagner5
bwagner5 approved these changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathan-innis jonathan-innis merged commit 25a784d into kubernetes-sigs:main Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwagner5 bwagner5 bwagner5 approved these changes

@spring1843 spring1843 Awaiting requested review from spring1843 spring1843 was automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonathan-innis @coveralls @bwagner5