Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade ginkgo and gomega #219

Merged
merged 1 commit into from
Feb 17, 2023
Merged

chore: upgrade ginkgo and gomega #219

merged 1 commit into from
Feb 17, 2023

Conversation

ellistarn
Copy link
Contributor

Fixes #

Description

How was this change tested?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ellistarn ellistarn requested a review from a team as a code owner February 17, 2023 21:12
bwagner5
bwagner5 approved these changes Feb 17, 2023
View reviewed changes
Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

coveralls commented Feb 17, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4207660459

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage remained the same at 80.968%
Files with Coverage Reduction New Missed Lines %
pkg/operator/controller/typed.go 2 93.55%
pkg/controllers/node/controller.go 7 73.53%
Totals Coverage Status
Change from base Build 4205380632: 0.0%
Covered Lines: 6356
Relevant Lines: 7850
💛 - Coveralls

@ellistarn ellistarn enabled auto-merge (squash) February 17, 2023 22:20
@ellistarn ellistarn merged commit 0613466 into kubernetes-sigs:main Feb 17, 2023
@ellistarn ellistarn deleted the ginkgo branch February 20, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwagner5 bwagner5 bwagner5 approved these changes

@njtran njtran Awaiting requested review from njtran njtran was automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ellistarn @coveralls @bwagner5