Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add events for do-not-evict blocking deprovisioning #224

Merged
merged 5 commits into from
Feb 24, 2023

Conversation

njtran
Copy link
Contributor

@njtran njtran commented Feb 24, 2023

Fixes #223

Description
Adds a new deprovisioning event for blocking deprovisioning. Consolidation has it's own bucket of items where this is already handled, but Expiration and Drift do not have this. This will be even more so used for Node Disruption Gates.

Added some suite tests as well.

How was this change tested?

  • make presubmit

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@njtran njtran requested a review from a team as a code owner February 24, 2023 21:14
@njtran njtran requested a review from bwagner5 February 24, 2023 21:14
@coveralls
Copy link

coveralls commented Feb 24, 2023

Pull Request Test Coverage Report for Build 4266861471

  • 27 of 57 (47.37%) changed or added relevant lines in 7 files are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.4%) to 80.787%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controllers/deprovisioning/consolidation.go 8 11 72.73%
pkg/controllers/deprovisioning/drift.go 7 16 43.75%
pkg/controllers/deprovisioning/events/events.go 0 9 0.0%
pkg/controllers/deprovisioning/expiration.go 7 16 43.75%
Files with Coverage Reduction New Missed Lines %
pkg/controllers/deprovisioning/controller.go 2 77.02%
pkg/controllers/node/controller.go 7 73.53%
Totals Coverage Status
Change from base Build 4246141448: -0.4%
Covered Lines: 6362
Relevant Lines: 7875

💛 - Coveralls

Copy link
Member

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@njtran njtran merged commit 3e5ec9b into kubernetes-sigs:main Feb 24, 2023
@njtran njtran deleted the emitEvents branch March 7, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emit event when node cannot be deprovisioned due to do-not-evict pod
4 participants