chore: Revert "feat: Machine Migration (#176)" #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-innis
force-pushed
the
revert-machine-migration-changes
branch
3 times, most recently
from
354c31c
to
b2ac9a9
Compare
jonathan-innis
force-pushed
the
revert-machine-migration-changes
branch
4 times, most recently
from
b300a7f
to
ed0bb76
Compare
bwagner5
reviewed
Mar 15, 2023
jonathan-innis
force-pushed
the
revert-machine-migration-changes
branch
3 times, most recently
from
00da3da
to
3ac320f
Compare
jonathan-innis
force-pushed
the
revert-machine-migration-changes
branch
from
3ac320f
to
0574709
Compare
jonathan-innis
force-pushed
the
revert-machine-migration-changes
branch
3 times, most recently
from
60f758c
to
40c3cf6
Compare
jonathan-innis
force-pushed
the
revert-machine-migration-changes
branch
from
40c3cf6
to
25df41e
Compare
njtran
reviewed
Mar 15, 2023
| Expect(nodes[0].Name).ToNot(Equal(node.Name)) | ||
| }) | ||
| It("should uncordon nodes when expiration replacement partially fails", func() { | ||
| It("should uncordon nodes when expiration replacement fails", func() { |
There was a problem hiding this comment.
Any reason you want to change this test? Was this how it was before?
There was a problem hiding this comment.
This is effectively the same test, since we are validating the ability of the test to uncordon after we decide to launch. Whether it's 3 or 1 I don't think makes much of a difference here
jonathan-innis
added a commit
to jonathan-innis/karpenter
that referenced
this pull request
Mar 16, 2023
…netes-sigs#241)" This reverts commit 9973eac.
jonathan-innis
added a commit
to jonathan-innis/karpenter
that referenced
this pull request
Mar 16, 2023
…netes-sigs#241)" This reverts commit 9973eac.
jonathan-innis
added a commit
to jonathan-innis/karpenter
that referenced
this pull request
Apr 4, 2023
…netes-sigs#241)" This reverts commit 9973eac.
jonathan-innis
added a commit
to jonathan-innis/karpenter
that referenced
this pull request
Apr 5, 2023
…netes-sigs#241)" This reverts commit 9973eac.
jonathan-innis
added a commit
to jonathan-innis/karpenter
that referenced
this pull request
Apr 5, 2023
…netes-sigs#241)" This reverts commit 9973eac.
jonathan-innis
added a commit
to jonathan-innis/karpenter
that referenced
this pull request
Apr 5, 2023
…netes-sigs#241)" This reverts commit 9973eac.
jonathan-innis
added a commit
to jonathan-innis/karpenter
that referenced
this pull request
Apr 5, 2023
…netes-sigs#241)" This reverts commit 9973eac.
jonathan-innis
added a commit
to jonathan-innis/karpenter
that referenced
this pull request
Apr 5, 2023
…netes-sigs#241)" This reverts commit 9973eac.
jonathan-innis
added a commit
to jonathan-innis/karpenter
that referenced
this pull request
Apr 5, 2023
…netes-sigs#241)" This reverts commit 9973eac.
jonathan-innis
added a commit
to jonathan-innis/karpenter
that referenced
this pull request
Apr 5, 2023
…netes-sigs#241)" This reverts commit 9973eac.
jonathan-innis
added a commit
to jonathan-innis/karpenter
that referenced
this pull request
Apr 5, 2023
…netes-sigs#241)" This reverts commit 9973eac.
jonathan-innis
added a commit
to jonathan-innis/karpenter
that referenced
this pull request
Apr 5, 2023
…netes-sigs#241)" This reverts commit 9973eac.
jonathan-innis
added a commit
to jonathan-innis/karpenter
that referenced
this pull request
Apr 8, 2023
…netes-sigs#241)" This reverts commit 9973eac.
jonathan-innis
added a commit
to jonathan-innis/karpenter
that referenced
this pull request
Apr 10, 2023
…netes-sigs#241)" This reverts commit 9973eac.
jonathan-innis
added a commit
to jonathan-innis/karpenter
that referenced
this pull request
Apr 11, 2023
…netes-sigs#241)" This reverts commit 9973eac.
jonathan-innis
added a commit
to jonathan-innis/karpenter
that referenced
this pull request
Apr 12, 2023
…netes-sigs#241)" This reverts commit 9973eac.
jonathan-innis
added a commit
to jonathan-innis/karpenter
that referenced
this pull request
Apr 13, 2023
…netes-sigs#241)" This reverts commit 9973eac.
jonathan-innis
added a commit
to jonathan-innis/karpenter
that referenced
this pull request
Apr 14, 2023
…netes-sigs#241)" This reverts commit 9973eac.
jonathan-innis
added a commit
to jonathan-innis/karpenter
that referenced
this pull request
Apr 18, 2023
…netes-sigs#241)" This reverts commit 9973eac.
jonathan-innis
added a commit
to jonathan-innis/karpenter
that referenced
this pull request
Apr 20, 2023
…netes-sigs#241)" This reverts commit 9973eac.
njtran
pushed a commit
to njtran/karpenter
that referenced
this pull request
May 3, 2023
* Revert "Revert machine migration changes (kubernetes-sigs#176) (kubernetes-sigs#241)" This reverts commit 9973eac. * Change owner reference to blockOwnerDeletion * Remove string logging for machine launch * Removing FailedInit since machine statusCondition captures it * Updated eventing on machines
njtran
added a commit
that referenced
this pull request
May 4, 2023
* chore: cleanup deprovisioning types * add inc * fix: add more visibility for when we can't consolidate (#292) * feat: Machine Migration (#273) * Revert "Revert machine migration changes (#176) (#241)" This reverts commit 9973eac. * Change owner reference to blockOwnerDeletion * Remove string logging for machine launch * Removing FailedInit since machine statusCondition captures it * Updated eventing on machines * action const * testfix * testfix2 * comments * rename * last * enum * fixcompile * export * fixredundancy * fixlogic * comment * renameVar --------- Co-authored-by: Todd Neal <tnealt@amazon.com> Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Description
Revert relevant changes in #176. Keeps some of the changes in the PR, but removes any changes that change the architecture from creating Nodes to modeling inflight nodes as machines.
How was this change tested?
make presubmitFOCUS=Integration make e2etestssucceededBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.