Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Cluster sync should have short requeue, no backoff #243

Merged

Conversation

jonathan-innis
Copy link
Member

@jonathan-innis jonathan-innis commented Mar 15, 2023

Fixes #

Description

  • Right now, the cluster state syncing mechanism will have an exponential backoff which can create large gaps between runs of the provisioning or deprovisioning loop. This should not be an exponential backoff but a continued one second poll
  • Also, the counter controller should use cluster state sync when overwriting the status. Otherwise, there is a potential for us to overwrite the status with a smaller value and shoot over our limits

How was this change tested?

make presubmit

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@coveralls
Copy link

coveralls commented Mar 15, 2023

Pull Request Test Coverage Report for Build 4438681326

  • 3 of 5 (60.0%) changed or added relevant lines in 2 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.1%) to 80.694%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controllers/deprovisioning/controller.go 3 4 75.0%
pkg/controllers/provisioning/provisioner.go 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/scheduling/requirements.go 2 98.5%
pkg/controllers/node/controller.go 3 79.41%
Totals Coverage Status
Change from base Build 4429673080: -0.1%
Covered Lines: 6554
Relevant Lines: 8122

💛 - Coveralls

Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathan-innis jonathan-innis merged commit 0b437c2 into kubernetes-sigs:main Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants