Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove ttlAfterNotRegistered value from settings #250

Merged

Conversation

jonathan-innis
Copy link
Member

Fixes #

Description

Remove ttlAfterNotRegistered value from settings, making this value no longer configurable but set to a heuristic value of 15m, which is the time between when the Machine is created and when we expect the Node to register with the cluster

How was this change tested?

make presubmit

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner March 27, 2023 18:32
@coveralls
Copy link

coveralls commented Mar 27, 2023

Pull Request Test Coverage Report for Build 4535367506

  • 7 of 7 (100.0%) changed or added relevant lines in 2 files are covered.
  • 23 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.02%) to 81.495%

Files with Coverage Reduction New Missed Lines %
pkg/controllers/machine/garbagecollect.go 2 81.82%
pkg/operator/controller/typed.go 2 93.55%
pkg/controllers/deprovisioning/controller.go 3 82.49%
pkg/controllers/node/controller.go 7 73.53%
pkg/controllers/deprovisioning/events/events.go 9 85.25%
Totals Coverage Status
Change from base Build 4493525613: -0.02%
Covered Lines: 6575
Relevant Lines: 8068

💛 - Coveralls

Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, don't forget to update docs and helm chart

@jonathan-innis
Copy link
Member Author

LGTM, don't forget to update docs and helm chart

This wasn't added to the main helm chart and the docs were never updated for this change ✅

@jonathan-innis jonathan-innis merged commit 4eedab8 into kubernetes-sigs:main Mar 27, 2023
@jonathan-innis jonathan-innis deleted the remove-ttl-not-registered branch March 27, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants