Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add settings validation and settings testing #40

Merged

Conversation

jonathan-innis
Copy link
Member

Issue #, if available:

Description of changes:

  • Adds a suite_test.go for the pkg/apis/config/settings package
  • Adds a Validate() function to adhere to a validation pattern for apis

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jonathan-innis jonathan-innis requested a review from a team as a code owner October 27, 2022 17:09
@jonathan-innis jonathan-innis requested a review from dewjam October 27, 2022 17:09
@jonathan-innis jonathan-innis enabled auto-merge (squash) October 27, 2022 17:10
@coveralls
Copy link

coveralls commented Oct 27, 2022

Pull Request Test Coverage Report for Build 3339872852

  • 23 of 25 (92.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 73.467%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/apis/config/settings/settings.go 20 22 90.91%
Totals Coverage Status
Change from base Build 3338717298: 0.2%
Covered Lines: 4768
Relevant Lines: 6490

💛 - Coveralls

@jonathan-innis jonathan-innis merged commit 463b028 into kubernetes-sigs:main Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants