-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Move the karpenter_build_info
metric to karpenter
#851
chore: Move the karpenter_build_info
metric to karpenter
#851
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
ace32ac
to
776ab2d
Compare
776ab2d
to
7bbcc7d
Compare
@jonathan-innis: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jonathan-innis, njtran The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Pull Request Test Coverage Report for Build 7137923870
💛 - Coveralls |
Fixes #N/A
Description
This change moves a merged PR from
aws/karpenter-provider-aws
into the commonkarpenter
code. This change exposes build information through a Prometheus metric. The change was originally merged with: aws/karpenter-provider-aws#5213 and is being transported into the common surface.How was this change tested?
make apply
on AWS with PrometheusBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.