-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove event filter for nodepool hash controller #864
Conversation
Pull Request Test Coverage Report for Build 7217110708
💛 - Coveralls |
@njtran: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jonathan-innis, njtran The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #N/A
Description
If a user removes the hash from the nodepool, the hash won't be added again until another event occurs, this could prevent drift from happening
There are four other controllers that filter out update events that don't modify the spec, which are all the correct behavior. One difference is we'll now enqueue for the nodeclaim/disruption controller so that if a user removes the status condition on a nodeclaim, we'll add it back in if necessary.
How was this change tested?
tested manually
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.