Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove event filter for nodepool hash controller #864

Merged
merged 3 commits into from
Dec 15, 2023

Conversation

njtran
Copy link
Contributor

@njtran njtran commented Dec 14, 2023

Fixes #N/A

Description
If a user removes the hash from the nodepool, the hash won't be added again until another event occurs, this could prevent drift from happening

There are four other controllers that filter out update events that don't modify the spec, which are all the correct behavior. One difference is we'll now enqueue for the nodeclaim/disruption controller so that if a user removes the status condition on a nodeclaim, we'll add it back in if necessary.

How was this change tested?
tested manually

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 14, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 14, 2023
@coveralls
Copy link

coveralls commented Dec 14, 2023

Pull Request Test Coverage Report for Build 7217110708

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 14 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.05%) to 80.113%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controllers/nodeclaim/disruption/controller.go 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/controllers/nodeclaim/disruption/controller.go 14 55.38%
Totals Coverage Status
Change from base Build 7205850137: 0.05%
Covered Lines: 7678
Relevant Lines: 9584

💛 - Coveralls

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 15, 2023
@k8s-ci-robot
Copy link
Contributor

@njtran: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-karpenter-test-1-27 ff9f1a0 link false /test pull-karpenter-test-1-27
pull-karpenter-test-1-28 ff9f1a0 link false /test pull-karpenter-test-1-28
pull-karpenter-test-1-29 ff9f1a0 link false /test pull-karpenter-test-1-29
pull-karpenter-test-1-26 ff9f1a0 link false /test pull-karpenter-test-1-26

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 15, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jonathan-innis, njtran

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jonathan-innis,njtran]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 28632c0 into kubernetes-sigs:main Dec 15, 2023
11 of 15 checks passed
@njtran njtran deleted the generationChanged branch December 26, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants