Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't panic on shutdown for nil nodepools for logging budgets #866

Merged
merged 2 commits into from
Dec 15, 2023
Merged

fix: don't panic on shutdown for nil nodepools for logging budgets #866

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
366a02b
fix: don't panic on shutdown for nil nodepools
njtran Dec 15, 2023
5a23b24
errorf
njtran Dec 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pkg/controllers/disruption/controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,8 @@ func (c *Controller) logAbnormalRuns(ctx context.Context) {
func (c *Controller) logInvalidBudgets(ctx context.Context) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline. I think the method signature should just be ValdiateBudgets() error so that we are less likely to miss error returns like this

nodePoolList, err := nodepoolutil.List(ctx, c.kubeClient)
if err != nil {
logging.FromContext(ctx).Debugf("listing nodepools, %s", err)
logging.FromContext(ctx).Errorf("listing nodepools, %s", err)
return
}
var buf bytes.Buffer
for _, np := range nodePoolList.Items {
Expand Down