-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow disruption when considering past disruption commands #988
Conversation
Pull Request Test Coverage Report for Build 7737762127
💛 - Coveralls |
fa38240
to
521e9f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
6eb2d67
to
a43f20d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jonathan-innis, njtran The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #N/A
Description
When considering deleting pods for scheduling simulations, we won't fail to disrupt if the pods that scheduled to uninitialized nodes were from an already deleting node. This is because they'll either be a node from a previous disruption command or a manually deleted node, either one of which we should assume is being disrupted and getting a replacement node as needed from the disruption or provisioning controller.
How was this change tested?
make presubmit
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.