fix: Use UUID as a precondition when calling the eviction API #998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
jonathan-innis
changed the title
jonathan-innis
force-pushed
the
dequeue-already-evicted-pods
branch
4 times, most recently
from
c8fbe26
to
733e091
Compare
Pull Request Test Coverage Report for Build 7849388308
💛 - Coveralls |
njtran
reviewed
Feb 9, 2024
jonathan-innis
force-pushed
the
dequeue-already-evicted-pods
branch
from
733e091
to
815fba0
Compare
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jonathan-innis, njtran The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jonathan-innis
added a commit
to jonathan-innis/karpenter
that referenced
this pull request
Feb 11, 2024
jonathan-innis
added a commit
to jonathan-innis/karpenter
that referenced
this pull request
Feb 11, 2024
jonathan-innis
added a commit
to jonathan-innis/karpenter
that referenced
this pull request
Feb 11, 2024
jonathan-innis
added a commit
to jonathan-innis/karpenter
that referenced
this pull request
Feb 11, 2024
jonathan-innis
added a commit
to jonathan-innis/karpenter
that referenced
this pull request
Feb 11, 2024
njtran
pushed a commit
that referenced
this pull request
Feb 13, 2024
njtran
pushed a commit
that referenced
this pull request
Feb 13, 2024
jigisha620
pushed a commit
to jigisha620/karpenter
that referenced
this pull request
Feb 16, 2024
jonathan-innis
added a commit
to jonathan-innis/karpenter
that referenced
this pull request
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #N/A
Description
This change ensures that when we attempt to evict a pod, we don't accidentally evict a pod with a namespaced name that was recently re-created and shifted onto another node. This is particularly critical for StatefulSets, where pods can be re-created quickly with the same name.
How was this change tested?
make presubmitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.