Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new k8s IPv6 configuration improvements to KIND #1154

Closed
2 tasks done
aojea opened this issue Dec 10, 2019 · 8 comments
Closed
2 tasks done

Add new k8s IPv6 configuration improvements to KIND #1154

aojea opened this issue Dec 10, 2019 · 8 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Milestone
v0.8.0

Comments

@aojea
Copy link
Contributor

aojea commented Dec 10, 2019 •
edited
Loading

What would you like to be added:

Currently we have to overcome kubernetes IPv6 configuraiton limitations in kind, i.e, hardcoding node ip

Why is this needed:

This will simplify the Kind glue and test better upstream IPv6 support on k8s

We can get rid of the NodeAddress dependency

kind/pkg/cluster/internal/kubeadm/config.go

Line 43 in 4c7854c

NodeAddress string

kind/pkg/cluster/internal/kubeadm/config.go

Line 408 in 4c7854c

node-ip: "{{ .NodeAddress }}"

kind/pkg/cluster/internal/kubeadm/config.go

Line 401 in 4c7854c

advertiseAddress: "{{ .NodeAddress }}"

@aojea aojea added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 10, 2019
@aojea aojea changed the title Add new IPv6 improvements to kind Add new k8s IPv6 configuration improvements to KIND Dec 10, 2019
@BenTheElder
Copy link
Member

that'll be nice :-)

@aojea aojea mentioned this issue Dec 20, 2019
Closed
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 13, 2020
@aojea
Copy link
Contributor Author

aojea commented Apr 13, 2020

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 13, 2020
@BenTheElder
Copy link
Member

we can still add this, we just need to guard on the k8s version, right?

@BenTheElder BenTheElder added this to the 2020 goals milestone Apr 25, 2020
@aojea
Copy link
Contributor Author

aojea commented Apr 25, 2020

we can still add this, we just need to guard on the k8s version, right?

yeah, see #1195 for reference

This was referenced Apr 25, 2020
Closed
Closed
@aojea
Copy link
Contributor Author

aojea commented Apr 25, 2020

:/

@aojea
Copy link
Contributor Author

aojea commented Apr 28, 2020

/close

Fixed by #1154

@k8s-ci-robot
Copy link
Contributor

@aojea: Closing this issue.

In response to this:

/close

Fixed by #1154

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BenTheElder BenTheElder modified the milestones: 2020 goals, v0.8.0 Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Milestone
v0.8.0
4 participants
@BenTheElder @aojea @k8s-ci-robot @fejta-bot