Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] testing fixes ... #3219

Closed
wants to merge 6 commits into from
Closed

Conversation

BenTheElder
Copy link
Member

#3218 clearly didn't resolve all of the issues with the new base image work, xref #3213

Temp PR just to try some things in CI since I can't repro locally yet.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 11, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from aojea and neolit123 May 11, 2023 23:17
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 11, 2023
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 11, 2023
@BenTheElder BenTheElder added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 11, 2023
@BenTheElder
Copy link
Member Author

OK so it's not fixed by newer packages (I was thinking systemd version is slightly older in bullseye than 22.04) and still present when switching back to ubuntu hackily, so it must be in containerd or runc

We have had version changes for those AND we changed the build.

https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_kind/3219/pull-kind-conformance-parallel-ga-only/1656809136643379200

@BenTheElder
Copy link
Member Author

I'm just appending commits here with changes for the history of commits vs tests, at least for now.
Later I'll file another PR with actual proposed fixes.

I'm pretty sure at this point it's a variation on opencontainers/runc#3849, we have runc ahead of the version in kubelet.

Thankfully the recent CVE fixes are in 1.1.5, so we can roll back as far as 1.1.5 for a bit while we decide what to do about Kubernetes releases < 1.24 (currently Kubernetes is bumping to 1.1.6, hopefully as far back as Kubernetes 1.24).

That also explains why I can't reproduce locally: this is not a problem with cgroupsv2, only v1.

However our main CI and many users are still on cgroups v1 ...

@BenTheElder BenTheElder deleted the bookworm branch May 12, 2023 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants