-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] testing fixes ... #3219
[WIP] testing fixes ... #3219
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
OK so it's not fixed by newer packages (I was thinking systemd version is slightly older in bullseye than 22.04) and still present when switching back to ubuntu hackily, so it must be in containerd or runc We have had version changes for those AND we changed the build. |
I'm just appending commits here with changes for the history of commits vs tests, at least for now. I'm pretty sure at this point it's a variation on opencontainers/runc#3849, we have runc ahead of the version in kubelet. Thankfully the recent CVE fixes are in 1.1.5, so we can roll back as far as 1.1.5 for a bit while we decide what to do about Kubernetes releases < 1.24 (currently Kubernetes is bumping to 1.1.6, hopefully as far back as Kubernetes 1.24). That also explains why I can't reproduce locally: this is not a problem with cgroupsv2, only v1. However our main CI and many users are still on cgroups v1 ... |
#3218 clearly didn't resolve all of the issues with the new base image work, xref #3213
Temp PR just to try some things in CI since I can't repro locally yet.