Switch to new containerd version - v1.7.11 #3475
Conversation
While we are at it, ability to set the desired containerd version in the make file itself, rather than hardcoding in the Dockerfile Signed-off-by: Davanum Srinivas <davanum@gmail.com>
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dims The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/XS
| FROM go-build as build-containerd | ||
| ARG TARGETARCH GO_VERSION | ||
| ARG CONTAINERD_VERSION="v1.7.5" |
There was a problem hiding this comment.
this is inconsistent with every other version in the file ..?
There was a problem hiding this comment.
i was mirroring ARG GO_VERSION in line 113 above.
There was a problem hiding this comment.
why don't keep the default version here?
Also, what is the benefit, this is more a personal commodity no? I don't imaging now we are going to release multiple images with different containerd versions
There was a problem hiding this comment.
@aojea this is to test newer versions of containerd in CI :)
There was a problem hiding this comment.
No, we don't want to release multiple images, we just ship with whatever version is in Makefile instead of in Dockerfile
There was a problem hiding this comment.
The go version had to be moved out for consistency with the rest of the repo, but the containerd version only exists here.
You can already do EXTRA_BUILD_OPT to pass additional args to the dockerfile (IIRC we even have a note in the README?), and we can already PR updates to the CONTAINERD_VERSION.
There was a problem hiding this comment.
Ack, was trying to make it more obvious/explicit with this PR. will just try to use EXTRA_BUILD_OPT
|
/assign @BenTheElder @aojea |
While we are at it, ability to set the desired containerd version in the make file itself, rather than hardcoding in the Dockerfile