Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid setting /kind/bin to 0644 #3477

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Avoid setting /kind/bin to 0644 #3477

merged 1 commit into from
Feb 12, 2024

Conversation

dgl
Copy link
Contributor

@dgl dgl commented Jan 11, 2024

This allows runc hooks to work when not running as root (such as with user namespaces, see issue #3436).

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 11, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @dgl. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 11, 2024
@aojea
Copy link
Contributor

aojea commented Jan 11, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 11, 2024
neolit123
neolit123 reviewed Jan 11, 2024
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

related to a previous change #3393

images/base/Dockerfile Outdated Show resolved Hide resolved
BenTheElder
BenTheElder reviewed Jan 11, 2024
View reviewed changes
images/base/Dockerfile Outdated Show resolved Hide resolved
@BenTheElder
Copy link
Member

We definitely want some version of this fix, but as-is this regresses versus why we started explicitly setting chmod

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 6, 2024
@dgl
Avoid setting /kind/bin to 0644
42024a9 
This allows runc hooks to work when not running as root (such as with
user namespaces).
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 6, 2024
@BenTheElder BenTheElder added this to the v0.22.0 milestone Feb 12, 2024
@BenTheElder
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 12, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, dgl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2024
BenTheElder
BenTheElder reviewed Feb 12, 2024
View reviewed changes
images/base/Dockerfile
@@ -42,8 +44,6 @@ COPY --chmod=0644 files/etc/systemd/system/kubelet.service.d/* /etc/systemd/syst
# Install dependencies, first from apt, then from release tarballs.
# NOTE: we use one RUN to minimize layers.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is out of date (we squash with multi-stage) and I'd probably move the chmod to it's own RUN, but those cleanups aren't important and I want to get this into the next release and we have some other bug fixes to prompt a quick follow-up release currently

@k8s-ci-robot k8s-ci-robot merged commit c4cadca into kubernetes-sigs:main Feb 12, 2024
9 checks passed
@BenTheElder BenTheElder mentioned this pull request Feb 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder left review comments

@neolit123 neolit123 neolit123 left review comments

@aojea aojea Awaiting requested review from aojea

Assignees

@BenTheElder BenTheElder

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v0.22.0
Development

Successfully merging this pull request may close these issues.
5 participants
@dgl @k8s-ci-robot @aojea @BenTheElder @neolit123