Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable CDI on containerd #3530

Closed
wants to merge 1 commit into from
Closed

enable CDI on containerd #3530

wants to merge 1 commit into from

Conversation

aojea
Copy link
Contributor

@aojea aojea commented Feb 26, 2024 •
edited
Loading

I think this is what we just need for supporting CDI devices in kind

I still need to test it

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 26, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 26, 2024
@aojea
Copy link
Contributor Author

aojea commented Feb 26, 2024

/kind feature
/hold
/assign @klueska

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/feature Categorizes issue or PR as related to a new feature. labels Feb 26, 2024
@klueska
Copy link

klueska commented Feb 27, 2024

Yes, this is all that is required. Though the specification of the dirs is unnecessary, as the ones you provide are the defaults.

See the following for how we have been enabling this in one of our repos via containerdConfigPatches:
https://github.com/NVIDIA/k8s-dra-driver/blob/main/demo/clusters/kind/scripts/kind-cluster-config.yaml#L20-L25

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 27, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, klueska

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@klueska
Copy link

klueska commented Feb 27, 2024

/lgtm

BenTheElder
BenTheElder reviewed Feb 27, 2024
View reviewed changes
images/base/files/etc/containerd/config.toml
@@ -40,3 +40,6 @@ version = 2
tolerate_missing_hugepages_controller = true
# restrict_oom_score_adj needs to be true when running inside UserNS (rootless)
restrict_oom_score_adj = false
# enable CDI https://github.com/cncf-tags/container-device-interface
enable_cdi = true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this default false? 👀

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@estesp @mikebrow can you help us here ? ^^

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, is a 2.0 thing containerd/containerd@c8e8a09

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct

@aojea
Copy link
Contributor Author

aojea commented May 24, 2024

it will be part of 2.0 containerd

@aojea aojea closed this May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estesp estesp estesp left review comments

@BenTheElder BenTheElder BenTheElder left review comments

@klueska klueska klueska approved these changes

@neolit123 neolit123 Awaiting requested review from neolit123

Assignees

@klueska klueska

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aojea @klueska @k8s-ci-robot @BenTheElder @estesp