-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI create multi node cluster failures by nerdctl #3534
Conversation
The error logs change to
It may relate to: containerd/nerdctl#1371 |
.github/workflows/nerdctl.yaml
Outdated
# Install nerdctl full package | ||
sudo curl -sSL https://github.com/containerd/nerdctl/releases/download/v${NERDCTL_VERSION}/nerdctl-full-${NERDCTL_VERSION}-linux-amd64.tar.gz | sudo tar -xvz -C /usr/local | ||
# Start Containerd | ||
sudo curl -sSL https://raw.githubusercontent.com/containerd/containerd/main/containerd.service > containerd.service |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer to have pinned dependencies in ci and not a moving target
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @aojea
It has been changed by using the containerd.service
included by nerd-full
pacakge.
sudo ctr version | ||
# Install CNI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are these no longer required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HI @aojea
Because the nerdctl-full contains the CNI dependency, it also includes:
# nerdctl (full distribution)
- nerdctl: v1.7.4
- containerd: v1.7.13
- runc: v1.1.12
- CNI plugins: v1.4.0
- BuildKit: v0.12.5
- Stargz Snapshotter: v0.15.1
- imgcrypt: v1.1.9
- RootlessKit: v2.0.1
- slirp4netns: v1.2.2
- bypass4netns: v0.4.0
- fuse-overlayfs: v1.13
- containerd-fuse-overlayfs: v1.0.8
- Kubo (IPFS): v0.26.0
- Tini: v0.19.0
- buildg: v0.4.1
ref to: https://github.com/containerd/nerdctl/releases/tag/v1.7.4
Using the nerdctl-full
instead of Minimal Package
can make the CI easy to maintaince, because the nerdctl manage the dependency version mapping.
0b5a969
to
7c0b28d
Compare
Signed-off-by: Kay Yan <kay.yan@daocloud.io>
/lgtm Thanks for keeping the CI healthy |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea, yankay The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I´ve seen this failure https://github.com/kubernetes-sigs/kind/actions/runs/8067092392/job/22036693761?pr=3530
|
This is still failing https://github.com/kubernetes-sigs/kind/actions/runs/8505888448/job/23295140055?pr=3563
|
The CI uses the container installed by
apt-get install docker-ce.
The version may not be right.So, it has been changed to the "nerdctl full package" to fix CI nerdctl test failures.
Fixes #3533