Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

promote stmcginnis to reviwer #3618

Merged
merged 1 commit into from
May 17, 2024
Merged

promote stmcginnis to reviwer #3618

merged 1 commit into from
May 17, 2024

Conversation

BenTheElder
Copy link
Member

Sean has been doing a lot of review and support work for some time now, we spoke and I'm proposing him as an official reviewer.

@BenTheElder
promote stmcginnis to reviwer
939fbf3 
Sean has been doing a lot of review and support work for some time now, we spoke and I'm proposing him as an official reviewer.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 17, 2024
@k8s-ci-robot k8s-ci-robot requested a review from aojea May 17, 2024 17:30
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 17, 2024
neolit123
neolit123 reviewed May 17, 2024
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @stmcginnis

@aojea
Copy link
Contributor

aojea commented May 17, 2024

+1

@aojea
Copy link
Contributor

aojea commented May 17, 2024

/lgtm

Thanks for all the hard work Sean

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 17, 2024
@k8s-ci-robot k8s-ci-robot merged commit aaee5cc into kubernetes-sigs:main May 17, 2024
21 checks passed
@BenTheElder BenTheElder deleted the owners branch May 17, 2024 18:03
@stmcginnis
Copy link
Contributor

Thanks everyone - glad to be able to help! 🎉

@dims
Copy link
Member

dims commented May 17, 2024

thanks @stmcginnis !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@aojea aojea Awaiting requested review from aojea

Assignees

@aojea aojea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@BenTheElder @k8s-ci-robot @aojea @stmcginnis @dims @neolit123