-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Kubeadm template format #3693
Fix Kubeadm template format #3693
Conversation
|
Welcome @dominicqi! |
Hi @dominicqi. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: dominic.qi <dominic.qi@jaco.live>
1359e2e
to
f96632a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the go playground reproducer.
{{- range $phase := .InitSkipPhases }}
is correct
/lgtm
/ok-to-test |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
nice catch!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, dominicqi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
When using
kubeProxyMode: none
The current kubeadm template will produceI found out the kubeadm template will drop the line breaker if
InitSkipPhases
is more than one, playground https://go.dev/play/p/-wJhmxW6w43 .