Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to go 1.22.6 #3707

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Conversation

BenTheElder
Copy link
Member

ahead of v0.24, we'll also want to follow up with base image bumps after this merges

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 13, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 13, 2024
@stmcginnis
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 13, 2024
@k8s-ci-robot
Copy link
Contributor

@BenTheElder: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kind-e2e-kubernetes-1-29 2a5bbee link true /test pull-kind-e2e-kubernetes-1-29

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@BenTheElder
Copy link
Member Author

{ failed [FAILED] kubelet should only have a single PID in the system (pidof returned "138075 258")

that's a neat flake. I'm going to go ahead and merge this though, there's NO way this PR has impacted inside the container yet.

@BenTheElder BenTheElder merged commit c6f155d into kubernetes-sigs:main Aug 13, 2024
26 of 29 checks passed
@BenTheElder BenTheElder deleted the latest-go-6 branch August 13, 2024 21:31
@BenTheElder
Copy link
Member Author

builds are in https://prow.k8s.io/?repo=kubernetes-sigs%2Fkind&type=postsubmit

then I'll "promote" with crane and open a PR (we do NOT want to reference staging directly and registry.k8s.io has other concerns we'll follow up on later ... no reason to rock the boat right this moment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants