aggregate masq sync errors

[sword-jin]

resolve the TODO, also we should break the loop if context is closed.

[k8s-ci-robot]

Hi @sword-jin. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[stmcginnis]

/ok-to-test

[BenTheElder]

/lgtm
/approve
/hold
(holding for @aojea input)

Also @aojea as a TODO should we consider something else in the future, like N consecutive failures instead of 3 lifetime errors?

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, sword-jin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [BenTheElder]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[BenTheElder]

thank you!

[stmcginnis]

should we consider something else in the future, like N consecutive failures instead of 3 lifetime errors?

I had the same thought as I started reviewing, but isn't that covered by the else clause:

errs = errs[:0]

[BenTheElder]

Oh, you're right.
We structured this a little unusually.

[aojea]

/lgtm

[BenTheElder]

/hold cancel