-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update client-go to v12.0.0 #733
Update client-go to v12.0.0 #733
Conversation
Welcome @shaneutt! |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: shaneutt The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @shaneutt. Thanks for your PR. I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@BenTheElder it seems there are some PR updating go dependencies, should we aggregate all of them in one? |
so I did some digging and actually we're only even importing client-go in the main module in order to get the homedir package which is pretty silly, we can just mimic that behavior and drop that dependency. /assign will tackle after #737 |
client-go is now only an indirect dependency by way of kustomize and in such a way that it is not tracked in go.mod after #744 I beleive that should replace this, please rebase and reopen if not. Thanks for the PR! |
client-go is now only an indirect dependency by way of kustomize and in such a way that it is not tracked in go.mod after #744 I beleive that should replace this, please rebase and reopen if not. Thanks for the PR! |
Resolves #732