-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed use of fish shell evaluation with (...) instead of bash style $(…) #659
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @vicenteherrera! |
Signed the individual Contributor License Agreement. |
Someone tested the old version and it worked well back in the day too. Can you provide an explanation why this works and the other one does not? |
The installation instruction was modified in #656, adding arm support. Nobody saw that we used bash syntax for this fish snippet. Thanks for fixing! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: corneliusweig, vicenteherrera The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixed use of fish shell evaluation with (...) instead of bash style $(…) in installation script in the specific fish section.
Tested and working well.