This repository has been archived by the owner on May 25, 2023. It is now read-only.
Handled minAvailable task everytime. #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Da K. Ma <klaus1982.cn@gmail.com>
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: k82cn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
size/S
k82cn
commented
Mar 4, 2019
| if assigned { | ||
| jobs.Push(job) | ||
| // Handle one assigned task in each loop. | ||
| if !assigned { |
There was a problem hiding this comment.
@Jeffwan , I reverted your PR. Because for training job, it need all pods to be started together; and for spark job, it requires master (driver) pod to be started firstly. If another case I missed, please let me know.
There was a problem hiding this comment.
@k82cn. Thanks! I will double check my cases.
k8s-ci-robot
added a commit
that referenced
this pull request
Mar 4, 2019
…ream-release-0.4 Automated cherry pick of #615: Handled minAvailable task everytime.
kevin-wangzefeng
pushed a commit
to kevin-wangzefeng/scheduler
that referenced
this pull request
Jun 28, 2019
Handled minAvailable task everytime.
kevin-wangzefeng
pushed a commit
to kevin-wangzefeng/scheduler
that referenced
this pull request
Jun 28, 2019
Handled minAvailable task everytime.
kevin-wangzefeng
pushed a commit
to kevin-wangzefeng/scheduler
that referenced
this pull request
Jun 28, 2019
Handled minAvailable task everytime.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Da K. Ma klaus1982.cn@gmail.com
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #598
Release note: